Docs: CRD reference topic edits #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karengermond
changed the title
karengermond
changed the title
marctc
reviewed
Nov 1, 2022
cmd/agent-operator/DEVELOPERS.md
Outdated
| Use the following to run the script in a container: | ||
|
|
||
| ``` | ||
| docker build -t grafana/agent-build-image:0.18.0 ./build-image |
There was a problem hiding this comment.
This version number is too specific, maybe we could just use latests as a tag.
marctc
approved these changes
Nov 1, 2022
karengermond
commented
Nov 1, 2022
cmd/agent-operator/DEVELOPERS.md
Outdated
| Use the following to run the script in a container: | ||
|
|
||
| ``` | ||
| docker build -t grafana/agent-build-image:0.18.0 ./build-image |
There was a problem hiding this comment.
Suggested change
| docker build -t grafana/agent-build-image:0.18.0 ./build-image | |
| docker build -t grafana/agent-build-image:latest ./build-image |
cmd/agent-operator/DEVELOPERS.md
Outdated
|
|
||
| ``` | ||
| docker build -t grafana/agent-build-image:0.18.0 ./build-image | ||
| BUILD_IMAGE=grafana/agent-build-image:0.18.0 USE_CONTAINER=1 make generate-crds |
There was a problem hiding this comment.
Suggested change
| BUILD_IMAGE=grafana/agent-build-image:0.18.0 USE_CONTAINER=1 make generate-crds | |
| BUILD_IMAGE=grafana/agent-build-image:latest USE_CONTAINER=1 make generate-crds |
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Edited
agent/operator/apis/monitoring/v1alpha1/
deployment.go
doc.go
group.go
types_integrations.go
types_logs.go
Will finish editing topics in this issue: #2452
Which issue(s) this PR fixes
Fixes #2451
Notes to the Reviewer
PR Checklist